ok, I can change that, though I guess the the performance gain will be
likely quite small in real world situations. Lets just hope no field
names will be ever called "null" then... ;-)
armin
On 10/29/2014 12:26 PM, Thomas RAFFIN wrote:
> Hi,
>
> I think it should be better to use "isset($recIn[$fld])" instead of
> "array_key_exists($fld, $recIn)" by considering performance.
>
>
> Le 14/10/2014 19:10, Armin Burger a écrit :
>> On 10/14/2014 07:50 AM, Raffaele Morelli wrote:
>>> On 14/10/14 at 12:32am, Armin Burger wrote:
>>>> yes, I guess this was always the way how it worked aslo in older
>>>> versions. It's not just for Postgis but also shapefile layers etc.
>>>>
>>>> The change to make it behave as you expected is to modify the
>>>> lib/query/query.php file at line 229 replacing the 4 subsequent lines
>>>> with the following ones:
>>>> foreach ($resultFields as $fld) {
>>>> if (array_key_exists($fld, $recIn)) {
>>>> $rec[$fld] = $recIn[$fld];
>>>> }
>>>> }
>>>>
>>>> Maybe a bit of testing would be needed but it could be changed in the
>>>> main code to always work like that, I agree that it seems more logic...
>>>>
>>>> armin
>>> Tested a little and works smoothly. IMHO it should be committed because when
>>> dealing with query results it's really useful to rearrange fields order and
>>> left
>>> db query untouched (even more with shapefile's dbf, I guess).
>> OK, committed to svn trunk
>>
>> ------------------------------------------------------------------------------
>> Comprehensive Server Monitoring with Site24x7.
>> Monitor 10 servers for $9/Month.
>> Get alerted through email, SMS, voice calls or mobile push notifications.
>> Take corrective actions from your mobile device.
>> http://p.sf.net/sfu/Zoho
>> _______________________________________________
>> pmapper-users mailing list
>> pmapper-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/pmapper-users
>>
>>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> pmapper-users mailing list
> pmapper-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pmapper-users
>
------------------------------------------------------------------------------
_______________________________________________
pmapper-users mailing list
pmapper-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmapper-users
