Branch: refs/heads/fix-usediamongoperator-rule
  Home:   https://github.com/pmd/pmd
  Commit: 378ba33f596e635fef8d762ec647d0a769a6e1c4
      https://github.com/pmd/pmd/commit/378ba33f596e635fef8d762ec647d0a769a6e1c4
  Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M 
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml

  Log Message:
  -----------
  Add failing test for UseDiamongOperatorRule

 - An IllegalStateException is produced when the inference context corresponds
to an invocation of an unresolved method.
 - The rule effectively can't determine if the diamond oeprator can be used, 
but the current message of
"overload resolution is not complete" is noisy, not actionable to the user
(the issue is a missing class in the auxclasspath, not the overload resolution),
and prevents the rule from continuing to analyze the current file.


  Commit: 8ef6042eb4931cefc12c3e5dffbf3bfc934643d3
      https://github.com/pmd/pmd/commit/8ef6042eb4931cefc12c3e5dffbf3bfc934643d3
  Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M 
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperatorRule.java

  Log Message:
  -----------
  Suppress the overload resolution failure and continue

 - This is probably not the best solution (maybe the Infer logic needs to remove
the check and handle it seamlessly?) but that code is too complex for me to 
make that call


Compare: https://github.com/pmd/pmd/compare/378ba33f596e%5E...8ef6042eb493


_______________________________________________
Pmd-commits mailing list
Pmd-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmd-commits
  • [pmd-commits] [pmd/pmd] 378ba3:... Juan Martín Sotuyo Dodero via Pmd-commits

Reply via email to