Branch: refs/heads/master
Home: https://github.com/pmd/pmd
Commit: 3735fd145b1385c914bcea1ac363866e33cc7ede
https://github.com/pmd/pmd/commit/3735fd145b1385c914bcea1ac363866e33cc7ede
Author: Andreas Dangel <andreas.dan...@pmd-code.org>
Date: 2024-07-27 (Sat, 27 Jul 2024)
Changed paths:
M docs/pages/release_notes.md
M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ASTMethod.java
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeBuilder.kt
M
pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeDumpTest.java
A
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/AccountTrigger.cls
A
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/AccountTrigger.txt
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CyclomaticComplexity.xml
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/performance/xml/OperationWithHighCostInLoop.xml
Log Message:
-----------
[apex] Fix parsing of triggers with declarations
Only the grandchildren of a trigger block were ending up in the tree,
but the direct children of triggerBlock were missing, e.g.
ForLoopStatement. This caused OperationWithHighCostInLoop to not
find the loop anymore in triggers.
This will probably fix other false negatives in triggers in
other rules as well.
Fixes #5139
Commit: 9ea10ecbe3b44885c5b696ddac4c157117f5ca0e
https://github.com/pmd/pmd/commit/9ea10ecbe3b44885c5b696ddac4c157117f5ca0e
Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com>
Date: 2024-07-27 (Sat, 27 Jul 2024)
Changed paths:
M docs/pages/release_notes.md
M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ASTMethod.java
M
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeBuilder.kt
M
pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/ast/ApexTreeDumpTest.java
A
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/AccountTrigger.cls
A
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/AccountTrigger.txt
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CyclomaticComplexity.xml
M
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/performance/xml/OperationWithHighCostInLoop.xml
Log Message:
-----------
Merge pull request #5146 from
adangel/issue-5139-apex-operationwithhighcostinloop
[apex] Fix parsing of triggers with declarations
Compare: https://github.com/pmd/pmd/compare/d2fbe14afaf2...9ea10ecbe3b4
To unsubscribe from these emails, change your notification settings at
https://github.com/pmd/pmd/settings/notifications
_______________________________________________
Pmd-commits mailing list
Pmd-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmd-commits
