On 05/01/2022 01:46, ABClf wrote:
No matter what choice will be done for sample-config, it's convenient
to have this line
written in starting config (commented or no), so that administrators
know that such option does exist.

Agreed.

As for me I have no preference here. I did not use that option ; testing now.

I always want this message, except when I'm testing/debugging PmWiki code and recipes and I reload a page multiple times. In such a case it only bothers me, but I have disabled it on my dev/test installation.


If the message written in the pop-up can be modified, I would prefer
"Quit this page" instead of "Quit website".

There is no such string, this is a browser-specific thing.

Our message is:

  $[Content was modified, but not saved!]

It is translatable in XLPage, but it is most likely ignored by the browsers.

It appears some websites were abusing this function in order to keep people from leaving their website. So now browsers mostly ignore what we set as a message, and they mostly display a generic message, in the language of the operating system.

Nevertheless, for us this is acceptable, we only need a generic warning.

Petko


Le mar. 4 janv. 2022 à 21:40, Simon <nzsk...@gmail.com> a écrit :

I couldn't agree more.
As there is no easy undo if you close without saving, and the consequences are severe - the loss of potentially a lot of work.

Also I think modern expectation (cf online editing such as google docs) is that you can't/shouldn't be able to accidentally lose input.

great idea

Simon


On Wed, 5 Jan 2022 at 00:23, Petko Yotov <5...@5ko.fr> wrote:

Currently by default PmWiki doesn't warn when people edit a page, and
try to move away from the edit form without saving.

We have $EnableNotSavedWarning but it needs to be enabled in config.php
by the administrator.

I added it to sample-config.php, but I wonder if instead we should
simply enable it by default.

I believe the setting dramatically improves the user experience and
saves a lot of frustration, especially with inexperienced editors and
administrators (who have yet to read the documentation and enable the
setting).

The setting, enabled, might possibly interfere with some custom edit
forms, although I am not aware of such a case, or with some of the
existing recipes that do exactly this.

If we enable it by default, anyone who doesn't need this feature can
disable it with

   $EnableNotSavedWarning = 0;

Even if there might be existing administrators who may be annoyed to add this line when they upgrade, I feel the benefit from having the feature
enabled outweighs the downside.

Thoughts?

Petko

_______________________________________________
pmwiki-users mailing list
pmwiki-users@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users

_______________________________________________
pmwiki-users mailing list
pmwiki-users@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users

_______________________________________________
pmwiki-users mailing list
pmwiki-users@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users

Reply via email to