Thanks for the quick review Pekka.

I've removed the commented code in test_clGetEventInfo.c and moved the
COMPLETE to after the

pocl_read_image call.

You can take a look again at
http://bazaar.launchpad.net/~bryan-w-bell/pocl/pocl/revision/


--Regards
Bryan

>Hi,
>
>* There's some commented out code in test_clGetEventInfo.c
>* The read/write image has queued/submitted/running/complete
>are all signaled before the actual action (pocl_read_image() call).
>I think COMPLETE should be signaled after the call?
>
>Otherwise LGTM.

>On 03/18/2013 11:26 AM, Bryan Bell wrote:
>> Hi, I've added some basic cl_event handling and a cl_event test.
>>
>> I've pushed as r655 to
>> http://bazaar.launchpad.net/~bryan-w-bell/pocl/pocl/revision/655
>>
>> Any comments? Could I get my changes merged in?
>>
>> make check TESTSUITEFLAGS="-k \!long" passed with my changes.
>>
>> --
>> -- Thanks!
>> Bryan
>> http://www.google.com/profiles/Bryan.W.Bell
>>
>>
>>
>>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
>
>
>
> _______________________________________________
> pocl-devel mailing list
> pocl-devel@...
> https://lists.sourceforge.net/lists/listinfo/pocl-devel
>
>
>
>--
>--Pekka





-- 
-- Regards
Bryan
Phone:530-355-5145
http://www.google.com/profiles/Bryan.W.Bell
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
pocl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pocl-devel

Reply via email to