How do you add -Werror to all CFLAGS and CXXFLAGS? I now know how to do this by modifying each Makefile.am -- is there also a more clever way?
-erik On 2013-08-28, at 14:40 , Kalle Raiskila <[email protected]> wrote: > Den Tue, 27 Aug 2013 13:00:25 -0400 > skrev [pocl-devel] -Werror: > >> Since we do not use -Wall, the number of warnings one receives while >> building pocl is typically small, and should be zero. Many >> "interesting" warnings (e.g. forgetting a return statement) are not >> even flagged. I thus suggest to use -Werror by default, which forces >> people to notice warnings and act on them. Personally, I also like >> -Wall, but -Wall sometimes warns about things that I consider >> perfectly reasonable, so we may not want to use it by default. > > I fully agree with your -Werror argument, but not with the -Wall one. > Yes there are a few pedantic-smelling things -Wall warns about, but > most of them still are trying to enforce good coding practices. > I say we should (aim to) enable -Wall too. If some particular warning > then really bugs someone, we can disable that particular warning with a > "-Wall -Wno-stupid-warning". > > kalle > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > _______________________________________________ > pocl-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/pocl-devel -- Erik Schnetter <[email protected]> http://www.perimeterinstitute.ca/personal/eschnetter/ My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu/.
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
