On Jun 9, 2014, at 4:51 , Pekka Jääskeläinen <[email protected]> wrote:
> On 06/09/2014 02:04 AM, Erik Schnetter wrote: >> I re-pushed my changes to a new branch "fp16-api". There, I left the fp16 > > I created a merge request out of it so I could add some inline comments to > the diff. I browsed it rather quickly (I need to go soon) and added a > couple of comments. Thanks. >> functions enabled, guarded by a new #ifdef FP16_API. This is enabled by >> default, but should probably be autoconfigured in the future. Can you have a >> look at this branch? > > I'm not sure should we have two macros after all. > > If OpenCL specs mandates to have the storage support for half, shouldn't it > be enabled by default and just have a macro (and autoconf check) for the > native compute (the fp16 extension) support? The TCE device driver should > have it on by default for now. It turns out I completely misread the OpenCL standard. Please ignore my comments on the pull request in this respect. Yes, half as storage format should always be defined, and yes, supporting fp16 operations should be handled by the existing fp16 macro, and no new macro is necessary. I will update my patch. >> I would like to disable the fp16 API for x86-64 in the future. > > Yes, the native fp16 support macro should be disabled by default. -erik -- Erik Schnetter <[email protected]> http://www.perimeterinstitute.ca/personal/eschnetter/ My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu/.
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://www.hpccsystems.com
_______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
