Hi, > Yes, let's keep both build systems usable fow now. OK.
> config.h is generated at configure time. install-paths.h is > generated at build time. My mistake, i misunderstood that. I thought it's done at automake time. > Actually, I'm not sure should we do it this way around. If > the packager uses DESTDIR, he won't run pocl from the DESTDIR, > but only from the prefix (the final installation location), > thus install-paths.h should reflect them? Well, it makes sense - also that's how i do it currently in cmake branch :) i use the final installation location (without DESTDIR) in pocl.icd, and the absolute path to build dir in pocl-tests.icd. The DESTDIR is pretty much only used at packaging time. Shall i go ahead and fix the install-paths et al to not use DESTDIR ? > > - replace PACKAGE_VERSION with POCL_VERSION > > Did this break something? Nope. Just all PACKAGE_ vars (in config.h) seemed redundant, since ctest doesnt use them. No problem to revert. > > Looking at the last item (SIZEOF), seems only used in > > lib/CL/devices/pthread/pthread.c to enable/disable half and double > > extensions... > > Yes, those should be left there so the "CPU" device drivers adapt to > the features of the CPU being used. Actually... there is a test specifically for broken sizeof(long) in OpenCL at configure.ac around line 934, which sets CL_DISABLE_LONG. That test is unrelated to all the SIZEOF_* tests. So that leaves the question - should pthread.c use SIZEOF_LONG(host long size in C) or CL_DISABLE_LONG(target long size OpenCL) ? and then the half extension.. Regards, -- mb ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
