Vous (Craig Ringer) avez écrit : > On Tue, 2009-07-21 at 15:51 +0200, Pierre Marchand wrote: > > Vous (Pierre Marchand) avez écrit : > > > I’m getting into your recent changes and had a couple of trivial issues > > > I wan’t to know if I must fix it myself or wait for you finish the > > > work. > > > > > > + podofo_config.h is not installed. > > > + HAVE_FONTCONFIG is publicly defined in podofo_config.h but not > > > prefixed with "PODOFO_". > > > > Going further I see there are rather more changes than I thought at first > > sight. > > It’s still not clear for me if podofo_config.h is intended to be public > > or just used at build time, I did notice it was missing when building > > apps relying on podofo that complained PDF_INT*_TYPENAME were not naming > > types. > > Hmm, that's a really good point, in that I've failed to separate what > should be public and what should be private (podofo compile-time only). > > *headdesk* > > After all the work I did getting Pdf3rdPtyForwardDecl.h etc set up to > hide PoDoFo's external header dependencies you'd think I'd not do > somthing this dumb. Sorry. > > I do think moving to the config.h approach will be clearer, I just need > to split it (and the compiler compat stuff) into public/private parts > and install the public parts.
yes. > > I'll see if I can look at it tomorrow. > > > Regarding deprecation of pdf_long as a ptrdiff_t, the reasons for it are > > quite clear > > I'd _really_ appreciate an explanation, then […] Hm, I must have been unclear myself. I just wanted to say that the reasons you exposed to deprecate it were rather convincing. > > That said, I was certainly wrong to change it in the sources as I did. > My only defense is that I was really tired and too thick to notice it. > I've reverted the alteration of the typedef. I do think pdf_long needs > to disappear though, and that it's currently used incorrectly where it > touches on file offsets, xref offsets, etc. I don’t think it’s so much of a problem, it’s trunk after all. As long as we know where we’re heading and can help to speedup things it’s fine. Now working on removing it from PdfStream, I’ll post a diff before committing. One more thing, I used to write things like: #if defined(pdf_long) PoDoFo::pdf_long mlen = 0; #else long mlen = 0; #endif stream->GetCopy(&mbuffer, &mlen); that allowed me to build code against 0.7.0 distribution as trunk as well (pdf_long has been introduced without version increment afaik) and I’m now wondering if it wouldn’t be the occasion to denote trunk with such a version number you proposed some times back: 0.7.99. -- Pierre Marchand ------------------------------------------------------------------------------ _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
