On 13/10/2009 10:41 PM, EXTERNAL Loch Sebastian (Firma Ferchau;
BhP/TEF17) wrote:
> Hi all,
> 
> finally I got the actual trunk compiled on VS 2003 (and VS 2005 too).

Great. I'm glad you got it going.

Sorry for being grumpy - you always post from a commercial address and
I'd figured you were using it in a product from the company. Lately, as
you can tell, I've been feeling a bit "used" thanks to various off-list
communication and I guess I've got a bit of a hair triggger :S

I'm happy to help out for a thesis project. I know you've already got
quite enough to worry about it, and no resources to speak of probably.

> 1.) Missing identifier "TryEnterCriticalSection"
> I just added the needed define _WIN32_WINNT 0x0400 to podofo_config.h.
> This probably not the right place, but maybe someone knows why the define
> PdfCompilerCompatPrivate.h didn't work...

Interesting. This still suggests that <windows.h> is being included
before it should be somehow on your build, though I can't really imagine
how. It'd be helpful to track down exactly what line the #define must be
added before to get the build to work, so we know where the problem arises.

> 2.) Definition errors 1 -> I removed the following stuff from
> a) PdfString
> PdfString::PdfString( const wchar_t* pszString )
>     : m_bHex( false ), m_bUnicode( true ), m_pEncoding( NULL )
> b) PfdFontMetrics
> double StringWidth( const wchar_t* pszText, unsigned int nLength = 0 ) const;
> unsigned long StringWidthMM( const wchar_t* pszText, unsigned int nLength = 0 
> ) const;
> 
> Does anyone need this methods? Could the trunk code can be adapted?

I've never bothered with wchar_t (I tend to work with UTF-8 strings most
of the time), but I presume Dom added that code for a reason. I'm pretty
sure it went in as part of his Unicode support work.

Rather than just deleting it, it'd be preferable if we could track down
why VS 2003 / 2005 was choking on it and get things working properly.

> 3.) Include order issues: windows.h before winsock2.h
> PdfFiltersPrivate.h includes "jpeglib.h" when set.
> This header again includes jconfig.h which includes windows.h.

Aaaaaah. Thankyou. My copy of libjpeg doesn't expose <windows.h> in its
public headers, which is why I didn't see any such issues. Odd difference.

> To fix this I included in PdfFiltersPrivate.h:
> #ifdef _WIN32
> #include <winsock2.h>
> #include <windows.h>
> #endif

Rather than doing that, because it's an internal header we can just
include PdfDefinesPrivate.h before the libjpeg headers.

What I'd prefer to do is get the inclusion of those headers out of the
.h and into the .cpp anyway, but they're there because they're needed
for fields in some of the classes. As it's a private, internal-only
header the fact that it exposes libjpeg etc interfaces doesn't matter
much, and we can just include PdfDefinesPrivate.h to make sure we get
<winsock2.h> before <windows.h> and everything else.

--
Craig Ringer

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to