Hi, Thank you very much for your patch. I commited it to SVN.
Is tr1::unique_ptr already available on all platforms (especially Visual
Studio is important for many users)? If so, I think it is a good idea to use
it for new code or where problems occur. Also, std::auto_ptr can be used in
lot's of places at the moment.
We had several discussions on whether to depend on boost or not. The
conclusion was to not depend on it in the core of PoDoFo. It is fine for tools
though.
Cheers,
Dom
Am Friday 11 March 2011 schrieb Nenad Novak:
> Hi,
>
> I have changed PdfFileInputStream to be able to return file pointer to
> under laying file. After that there is no need to open another stream to
> same image file. PdfFileInputStream will maintain object lifetime (FILE*),
> if there is exception raised from jpeg code. There is also a handler which
> should make jpeg lib more quiet.
>
> Some PNG files can have alpha component, for gray and RGB images. Also they
> may use indexed colors, and without patch they will not render or load
> correctly.
>
> Resource acquisition is still on lot of places very questionable. What
> about using tr1::unique_ptr, or boost::scoped_ptr?
>
> BTW, throwing exception from jpeg lib C code, will still terminate C++
> program, unless jpeg lib is compiled with -fexceptions. At least that was a
> case on my system.
>
>
> Regards,
> Nenad
--
Dominik Seichter - [email protected] - http://domseichter.blogspot.com
KRename - http://www.krename.net - Powerful batch renamer for KDE
KBarcode - http://www.kbarcode.net - Barcode and label printing
PoDoFo - http://podofo.sf.net - PDF generation and parsing library
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d
_______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
