Hi Evgeny,

Thanks, I think i fixed the documentation and made clear that PdfEncoding is 
only deleted if PdfEncoding::IsAutoDelete() == true.

You are also right that naming of Pdf*Encoding and PdfFont* is not consistent. 
It is not nice but I do not think it is worth the hassle of renaming them.

If you want to provide a patch, feel free! I will commit it. Users should not 
be affected to much, as they should all include podofo.h instead of individual 
headers. Only a few PdfEncoding class names would change. I personaly prefer 
the PdfFont* names as it makes clear what belongs together.

Best regards,
        Dom

Am Saturday 23 July 2011 schrieb Pakhomov Evgeny:
> Hello.
> Documentation says that PdfEncoding object:
> 1) WILL NOT be owned and deleted by PdfFont object;
> 2) WILL be owned and deleted by PdfFontSimple object;
> 3) WILL NOT be owned and deleted by other PdfFont subclasses.
> 
> But that's wrong. In fact all of PdfFont subclasses use virtual ~PdfFont()
> which WILL delete it's PdfEncoding object IF PdfEncoding::IsAutoDelete()
> returns true. And it returns false only for PdfSimpleFont subclasses. For
> PdfDifferenceEncoding and PdfIdentityEncoding it's up to user to choose
> ownership of objects of this classes by setting bAutoDelete constructor's
> parameter to true or false.
> 
> 
> Also (I'm just curious) why different fonts are named as PdfFont* while
> different encodings are names as Pdf*Encoding?
> 
> ---------------------------------------------------------------------------
> --- Magic Quadrant for Content-Aware Data Loss Prevention
> Research study explores the data loss prevention market. Includes in-depth
> analysis on the changes within the DLP market, and the criteria used to
> evaluate the strengths and weaknesses of these DLP solutions.
> http://www.accelacomm.com/jaw/sfnl/114/51385063/
> _______________________________________________
> Podofo-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/podofo-users


-- 
Dominik Seichter - [email protected] - http://domseichter.blogspot.com
KRename  - http://www.krename.net  - Powerful batch renamer for KDE
KBarcode - http://www.kbarcode.net - Barcode and label printing
PoDoFo - http://podofo.sf.net - PDF generation and parsing library

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to