Hi,

even though I'm not Christian Sakowski, I can do that conversion to
a patch too, right ;-) ?
I herewith disclaim all authorship and copyright in the code change
described by the patch file attached to this e-mail, I only assume
the transformation from what Christian Sakowski posted on this list
is legal.
@Reviewers/Committers: Please review the change (give all credit to
Christian Sakowski, of course!) and likewise commit it if accepted.

Best regards, mabri

P.S. Please also review the changes contributed by me as patches.



----- Original Message -----
From: zyx <z...@litepdf.cz>
To: podofo-users@lists.sourceforge.net
Sent: 17:28 Wednesday, 25.November 2015
Subject: Re: [Podofo-users] Bug in GetMultiLineTextAsLines

On Wed, 2015-11-25 at 17:06 +0100, Christian Sakowski wrote:
> I found the bug and it works perfectly now.

    Hi,
that's great, but any mail client can garble the message body, making
the patch full of unneeded changes.

Could you provide a diff/patch for your change, please? If you do not
use the svn checkout, then just copy the original file as
PdfPainter.cpp.orig, then make the change into the PdfPainter.cpp and
then generate the patch with a diff command:
   $ diff -up PdfPainter.cpp.orig PdfPainter.cpp >podofo.patch
Then _attach_ the resulting podofo.patch file to an email message and
send it here.
    Thanks and bye,
    zyx

-- 
http://www.litePDF.cz                                 i...@litepdf.cz
Index: src/doc/PdfPainter.cpp
===================================================================
--- src/doc/PdfPainter.cpp	(revision 1693)
+++ src/doc/PdfPainter.cpp	(working copy)
@@ -1013,8 +1013,8 @@
         if( IsNewLineChar( *pszCurrentCharacter ) ) // hard-break! 
         {
             vecLines.push_back( PdfString( pszLineBegin, pszCurrentCharacter - pszLineBegin ) );
-            ++pszCurrentCharacter; // skip the line feed
-            pszLineBegin = pszCurrentCharacter;
+
+            pszLineBegin = pszCurrentCharacter+1;// skip the line feed
             startOfWord = true;
             dCurWidthOfLine = 0.0;
         }
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to