> On Tue, 2018-02-27 at 16:54 +0100, zyx wrote: > > this introduces new compiler warning in podofosign (interestingly > > only at this place, good job): > > Hi again, > I forgot to add, I do not think that implicit casts cause any real > issue, compilers are able to claim warnings when it's a problem these > days, thus it should be better to address them, than to hunt for > static_cast<>-s or anything like that, which can work for the external > library API of version X, but would cause similar casts with version Y > (like when the API changes between X and Y). > > There are surely issues with higher priority and higher impact than > this (not that having a clean code is a wrong thing, it's the opposite; > compilers usually do know why they claim certain issues and having the > code without compiler warnings is a good goal to achieve). > > Just my opinion.
Zyx, /Replying out of thread (because I didn't receive some posts to the list - sourceforge using various servers for sending and some have PTR records awfully configured - fixed it on my side now, I guess)./ Indeed. For now, such hunts are the only contributions I can do for the project. :) > this introduces new compiler warning in podofosign (interestingly only > at this place, good job): > > podofosign.cpp: In function ‘void > sign_with_signer(PoDoFo::PdfSignOutputDevice&, X509*, EVP_PKEY*)’: > podofosign.cpp:226:16: warning: comparison between signed and unsigned > integer expressions [-Wsign-compare] Will recheck and adjust podofosign.cpp. I agree the addition of static_cast in most places is not of great importance - nor urgent in any way, except to hide those warnings confirmed to be non-significant, such that when other warnings re-appear they are more likely to trigger attention. When you get used to see, and ignore, tens or hundreds of insignificant warnings on each build, it is harder to spot those that should trigger real concern. The patch also has some other kind of fixes: at some places it was a matter of selecting a better type for some variable, to eliminate the need for any cast. And there are the recent printf format string changes : at some places it now expects a 64 bits value (due to the format specifier) and some arguments are 32 bits when compiling in 32 bits mode (size_t returned from strlen for instance), that's why the static_cast are needed (really) in those places. -- Best Regards, Meilleures salutations, Met vriendelijke groeten, Olivier Mascia ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
