On Fri, 2020-06-12 at 11:28 +0200, Christian Sakowski wrote:
> this patch is currently not part of the trunk but very important! Can
> someone check this in, please?
Hi,
thanks for the reminder. I missed it in the mailing list.
That patch, even the file itself, is a nice mix of different coding
styles. Not a big deal, just being noticed.
It introduced a new compiler warning here:
.../src/podofo/doc/PdfImage.cpp: In function ‘void
PoDoFo::LoadFromPngContent(png_structp, png_infop, PoDoFo::PdfImage*)’:
.../src/podofo/doc/PdfImage.cpp:934:91: warning: suggest parentheses around
‘&&’ within ‘||’ [-Wparentheses]
934 | color_type == PNG_COLOR_TYPE_PALETTE && png_get_valid(pPng,
pInfo, PNG_INFO_tRNS) && png_get_tRNS(pPng, pInfo, &paletteTrans,
&numTransColors, NULL))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
which I fixed before committing. I also made the LoadFromPngContent() a
static function.
I cannot really test this, thus I trust you with this.
The patch had been committed as r2011:
http://sourceforge.net/p/podofo/code/2011
Thanks and bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
