On Thu, 23 Feb 2023 at 17:39, zyx <z...@gmx.us> wrote: > maybe Path::GetContent(), or Path::AsString()? As the GetString() feels > like there might be also SetString()
Maybe PdfPainter/Path::GetContentString()? > (which it should, right? When one > wants to re-apply the path with this higher level API - the Path object > currently does not seem to be capable of "filling existing data" to it, > neither merge it with another Path object). I mean, the string is not > enough, if you cannot apply it anywhere - it would be nice to have a > higher level API for it. I think I can add a feature to add a path to another path. But creation from string would require parsing and validation to handle the current point, so I'm definitely not adding it now. We should try to release a 0.10 with a feature set that is in pair with what people would expect from 0.9.x to do reasonably good. All the rest is a missing feature and some loving care in form of PRs would be very welcome. > Yes, that's okay. I'm not sure we are on the same page. I meant > something like: [...] > just to re-use the Path class. You know, to limit different code paths. > It should be easier for testing too, and it might be a bit more > consistent, due to no shortcuts in the code, which is supposed to do > exactly the same thing as another part of the code. > Yes, we were talking about something different. Now I understand what you meant but in the way you suggest unnecessary buffer allocations and checks would be done. I agree with you that testing would be easier by reusing the existing path class inside PdfPainter, but I also think that PdfPainter and PdfPainterPath are coupled enough as it is now. We must be honest with ourselves and admit that PoDoFo was/is not super well unit tested, and that's not because it's intrinsically hard to test but because some of its devs (including/especially me) don't like/don't have much time to write tests, or have other unpublished test suites. I began to improve the current situation in PdfPainter but until one show up with a big amount of tests in a row I don't see it improving quickly. Cheers, Francesco _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
