On Tue, Jul 31, 2001 at 07:59:24AM +0200, Anton Berezin wrote:
> On Tue, Jul 31, 2001 at 12:56:35AM -0400, Rocco Caputo wrote:
> > On Mon, Jul 30, 2001 at 01:39:56AM +0200, Anton Berezin wrote:
>
> > > And third, there are some `use of undefined value' occurences there
> > > at the moment.
> >
> > Agreed, agreed, and applied x2.
>
> :-)
>
> It looks like one of these was lost actually:
[patch to default POSTed content lengths to 0?]
I wasn't sure whether it did anything useful, so I opted to leave it
out. Your subsequent patch to return 411 (length required) or 400
(bad request) is much nicer, and I applied that one.
[several more cleanup patches]
Excellent! I had to restructure some of them to stay within 79
columns (call me old-fashioned :), but they should all have been
applied.
> I did not do the same testing for content_length() when there's the
> second get() invocation for it is supposed to be tested already, at
> least in the case of POST (and in the case of GET, and now HEAD, we
> never reach that point anyway, and we don't do the right thing in case
> of any other request method anyway).
How are you testing Filter::HTTPD? I'm resorting to running
samples/httpd.perl to make sure things vaguely work, but I'd like to
add an automated test someday. If you have one, could I use it?
-- Rocco Caputo / [EMAIL PROTECTED] / poe.perl.org / poe.sourceforge.net
