On Wed, 2007-05-23 at 02:52 +0900, Daisuke Maki wrote: > When I initially was optimizing my crawler, I just replaced all the > actions to append and/or modify $request->[REQ_CONTENT] to something > that wrote to an open file descriptor, which worked, but I still wanted > to do some more experimenting without being bothered by upgrades to > PoCo::Client::HTTP. Are you subclassing ::Request? If not, how can we change it so that that would be an option? Copy-and-pasting the rest just to change where to store the content seems suboptimal
> Shall I remove the RequestFactory bit? I still think that it *could* be > useful, but you're right, no I don't have any particular reason to make > it configurable at this point. Yeah, I bet there are some uses for it, but I think it's better to wait with making it configurable until someone actually needs it. Oh, and it's really great that you're adding tests, but when I was working on it, I was trying to avoid doing actual network requests. Could you do that too? Check out 05_request.t and 06_factory.t to see what I mean (the tests could probably go in 06_factory.t even) Thanks for working on this, Martijn
