I have not applied it. Was leaving that to you but will do it if you don't
get around to it.
-- Glen
----- Original Message -----
From: "Andrew C. Oliver" <[EMAIL PROTECTED]>
To: "POI Development" <[EMAIL PROTECTED]>
Sent: Thursday, March 14, 2002 10:27 AM
Subject: Re:
[PATCH]org.apache.poi.hssf.usermodel.HSSFCell#setCellValue(Calendar value)
> On area I know is wrong is the CellFormat stuff. But we have no
> documenation on what the format strings are in other regions. The Excel
> 97 Dev kit only documents the version of Excel distributed to English
> offshoot cultures. The date stuff should certainly be fixed. Did you
> apply this glen or should I? Hopefully we can get some unit tests to
> break in non-localized areas. It seems like just the kind of thing that
> a good unit test could check. Thoughts?
>
> On Wed, 2002-03-13 at 16:58, Glen Stampoutlzis wrote:
> > It would be great to ensure POI is localized correctly. Personally I
have
> > little knowledge in this area but I'm prepared to be educated. Hope you
can
> > help us in this area.
> >
> > Regards,
> >
> > Glen
> >
> >
> > ----- Original Message -----
> > From: "acoliver" <[EMAIL PROTECTED]>
> > To: <[EMAIL PROTECTED]>
> > Sent: Thursday, March 14, 2002 6:41 AM
> > Subject: Re: [PATCH]
> > org.apache.poi.hssf.usermodel.HSSFCell#setCellValue(Calendar value)
> >
> >
> > > Glen,
> > >
> > > This is a good point.
> > >
> > > llefevre,
> > >
> > > Can you supply a unit test for this as well (or update the existing
unit
> > > test)? We need to get unit tests working for these things in order to
> > > really have any hope of localization. (Then we can get real data back
> > like
> > > happened with the comma vs decimal money issue).
> > >
> > > BTW I tried to respond to you about localization but my ISP's mail
server
> > > crashed. Basically Localization/Internationalization is a priority
for
> > us,
> > > but we need good folks like you to do exactly what youre doing!
You'll
> > have
> > > a better understanding of what the non-US/UK/AU version of Excel does
we
> > can
> > > only guess. (BTW the US/UK/AU versions of excel are all roughly the
same
> > > version from what I've read if anyone was wondering)
> > >
> > > As a matter of procedure, best to submit patches into bugzilla so that
> > they
> > > don't get lost, just label them [PATCH]. It will be posted to the
list by
> > > bugzilla as well.
> > >
> > > Thanks for helping out! I'll apply this shortly if flash-glen doesn't
> > beat
> > > me to it.
> > >
> > > -Andy
> > >
> > > >On Wed, 13 Mar 2002 19:04:34 0100 =?iso-8859-1?B?TG/vYyBMZWbodnJl?=
> > > <[EMAIL PROTECTED]> wrote.
> > > >--- HSSFCell.java Wed Mar 13 17:53:21 2002
> > > > HSSFCellNew.java Wed Mar 13 17:53:02 2002
> > > >@@ -72,6 72,7 @@
> > > > import org.apache.poi.hssf.record.ExtendedFormatRecord;
> > > >
> > > > import java.util.Date;
> > > > import java.util.Calendar;
> > > >
> > > > /**
> > > > * High level representation of a cell in a row of a spreadsheet.
> > > >@@ -631,6 632,19 @@
> > > > public void setCellValue(Date value)
> > > > {
> > > > setCellValue(HSSFDateUtil.getExcelDate(value));
> > > > }
> > > >
> > > > /**
> > > > * set a date value for the cell. Excel treats dates as numeric
so
> > you
> > > >will need to format the cell as
> > > > * a date.
> > > > *
> > > > * @param value the date value to set this cell to. For
formulas
> > > >we'll set the
> > > > * precalculated value, for numerics we'll set its value.
For
> > > >othertypes we
> > > > * will change the cell to a numeric cell and set its
value.
> > > > */
> > > > public void setCellValue(Calendar value)
> > > > {
> > > > setCellValue(value.getTime());
> > > > }
> > > >
> > > > /**
> > > >
> > >
> >
> >
> --
> http://www.superlinksoftware.com
> http://jakarta.apache.org/poi - port of Excel/Word/OLE 2 Compound
> Document
> format to java
> http://developer.java.sun.com/developer/bugParade/bugs/4487555.html
> - fix java generics!
> The avalanche has already started. It is too late for the pebbles to
> vote.
> -Ambassador Kosh
>
