Re: HSSFRow bug ?

Mon, 08 Apr 2002 05:28:05 -0700

Good night!
 
I just submitted a testcase and a fix.
 
Thanks for the report,
 
Regards,
 
Glen Stampoultzis  (TriNexus Pty Ltd)
+63 3 9753-6850     0402 835 458
ICQ:  62722370    EMail:  [EMAIL PROTECTED]
----- Original Message -----
Sent: Monday, April 08, 2002 7:19 PM
Subject: HSSFRow bug ?

Good Morning :)))
 
I Find something interesting in your source code.
 
in HSSFRow :
    private short findLastCell(short lastcell)
    {
        short     cellnum = (short)(lastcell - 1);
        HSSFCell r      = getCell(cellnum);
 
        while (r == null)
        {
            r = getCell(--cellnum);
        }
        return cellnum;
    }
ok, by the logic . what if I have created a only cell that for example will be in place 20, and then I am trying to remove it. This function will run in cycles , because it cant find a cell that isn't null.
 
For this case there is 2 solutions.
1. The logic should be that it will be always 0 cell .
2. We got a need to fix it bug 
            while ((r == null) && (cellnum >= 0)) 
 
Any takers, or I will submit a patch :) ?
 
                                                    Thanks,
                                                        Waiting For Answer :))
 
 
 
 
 

Reply via email to