The comment was aimed at whether checkstyle would be useful for this project
given it's lack of standards. It was not a standards discussion as such.
We have already been down that path and you know my feelings on that
subject.
Regards,
Glen Stampoultzis (TriNexus Pty Ltd)
+63 3 9753-6850 0402 835 458
ICQ: 62722370 EMail: [EMAIL PROTECTED]
----- Original Message -----
From: "Andrew C. Oliver" <[EMAIL PROTECTED]>
To: "POI Development" <[EMAIL PROTECTED]>
Sent: Friday, April 12, 2002 9:42 AM
Subject: Re: Checkstyle code check on POI: 10827 errors
> -1 on letting this degrade into a long pedantic discussion on where one
> should put their braces or whether to use _variables or not. Its not
> productive and has been addressed.
>
> On Thu, 2002-04-11 at 19:20, Glen Stampoultzis wrote:
> > Given that our coding standard is very "relaxed" I don't think
checkstyle
> > will be very helpful for us unless you turn most of the checks off.
> >
> > -- Glen
> >
> > ----- Original Message -----
> > From: "Nicola Ken Barozzi" <[EMAIL PROTECTED]>
> > To: <[EMAIL PROTECTED]>
> > Sent: Friday, April 12, 2002 12:53 AM
> > Subject: Checkstyle code check on POI: 10827 errors
> >
> >
> > > I have included checkstyle in my local POI version.
> > >
> > > Running it with the Sun conventions, we had 10827 errors.
> > >
> > > An example:
> > > "
> > >
C:\jbprojects\jakarta-poi\src\java\org\apache\poi\util\ShortField.java:73:
> > > varia
> > > ble '_offset' must match pattern '^[a-z][a-zA-Z0-9]*$'.
> > >
C:\jbprojects\jakarta-poi\src\java\org\apache\poi\util\ShortField.java:86:
> > > '{' s
> > > hould be on the previous line.
> > >
C:\jbprojects\jakarta-poi\src\java\org\apache\poi\util\ShortField.java:88:
> > > '{' s
> > > hould be on the previous line.
> > >
> >
C:\jbprojects\jakarta-poi\src\java\org\apache\poi\util\ShortField.java:107:
> > > '{'
> > > should be on the previous line.
> > > "
> > >
> > > As you see, I still have to tell checkstyle not to bark on such stupid
> > > "errors" ;-P
> > >
> > > --
> > > Nicola Ken Barozzi [EMAIL PROTECTED]
> > > - verba volant, scripta manent -
> > > (discussions get forgotten, just code remains)
> > > ---------------------------------------------------------------------
> > >
> >
> >
> --
> http://www.superlinksoftware.com
> http://jakarta.apache.org/poi - port of Excel/Word/OLE 2 Compound
> Document
> format to java
> http://developer.java.sun.com/developer/bugParade/bugs/4487555.html
> - fix java generics!
> The avalanche has already started. It is too late for the pebbles to
> vote.
> -Ambassador Kosh
>
