DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10976>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10976 [Patch] Unicode Support for sheetname , refactor SSTDeserializer & UnicodeString class [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |INVALID ------- Additional Comments From [EMAIL PROTECTED] 2002-08-15 20:15 ------- Okay I had more time to review this. I like the idea but I hate the implementation. (no offense). My objection: EVERY method that says "lifted from..." ... Lets fight this code rot right now. Move those to common utility functions (perhaps StringUtility for instance) and remove them from any classes they originate from (SSTRecord for instance). Cutting and pasting is not a good thing. I don't want to fix string functions everywhere, I want one authorative routine for EACH way excel handles them. Do that and comment it liberally and I'll reapply it.. the "arraycopy" function seems silly to me since it just calls to System.arraycopy... . . why do we have that? Once you've fixed it, please reattach and reopen this bug.... Thanks, Andy -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
