Hi Andy,
I'm not sure my first email to dev list got delivered, so I just send this email again. I've tried to submit a patch but having problem creating the patch using diff -u command. Simply because I don't have a tool that have this command. I tried to download cygwin and WinCvs but cannot run neither of them after installed. (cannot find dlls.) I wonder if you can point me some links to try to get this usability. Thanks a lot. BTW I only have Windows NT to use. an -----Original Message----- From: Andrew C. Oliver [mailto:[EMAIL PROTECTED]] Sent: Thursday, October 03, 2002 2:30 PM To: 'POI Users List' Subject: Re: Fix for sheet name to support DBCS Hi, As much as I would like to see that fixed, I simply do not have time to apply patches that are not submitted in the proper format per the instructions here: http://jakarta.apache.org/poi/getinvolved/index.html If you can submit it per those instructions I'll certainly apply it. Please update the appropriate unit tests as well. (Make a unit test that sets a sheet to a japanese name and then reads it back in... The reason this keeps not quite getting fixed is due to us not having the unit test) (it actually takes me as long to do it myself as to apply a malformed patch...sorry) Also please keep this kind of communication on the poi-dev list as its a development issue. Thanks, Andy On Thu, 2002-10-03 at 15:52, An Feng-I Chen wrote: > Andy, > > I've tried poi 1.8 build 0919 > HSSFWorkbook.setSheetName(sheetNum,sheetName,encodingFalg) but it doesn't > display sheet name in Japanese correctly. So I modified > BoundSheetRecord.serialize method. Using setSheetName along with this fix, > it works. Please try it and hope it can be added to the library. > > public int serialize( int offset, byte[] data ) > { > LittleEndian.putShort( data, 0 + offset, sid ); > LittleEndian.putShort( data, 2 + offset, (short) ( 8 + > getRawSheetnameLength() ) ); > LittleEndian.putInt( data, 4 + offset, getPositionOfBof() ); > LittleEndian.putShort( data, 8 + offset, getOptionFlags() ); > data[10 + offset] = (byte) ( getSheetnameLength() ); > data[11 + offset] = getCompressedUnicodeFlag(); > > try { > String unicodeString = new > String(getSheetname().getBytes("Unicode"),"Unicode"); > if ( ( field_4_compressed_unicode_flag & 0x01 ) == 1 ) { > StringUtil.putUncompressedUnicode( unicodeString, data, 12 + > offset ); > } > else { > StringUtil.putCompressedUnicode( unicodeString, data, 12 + > offset ); > } > } catch (Exception e) { > if (getOptionFlags() == 0) { > StringUtil.putCompressedUnicode(getSheetname(), data, 12 + > offset); > } > else { > StringUtil.putUncompressedUnicode(getSheetname(), data, 12 + > offset); > } > } > > return getRecordSize(); > } > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- http://www.superlinksoftware.com - software solutions for business http://jakarta.apache.org/poi - Excel/Word/OLE 2 Compound Document in Java http://krysalis.sourceforge.net/centipede - the best build/project structure a guy/gal could have! - Make Ant simple on complex Projects! The avalanche has already started. It is too late for the pebbles to vote. -Ambassador Kosh -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
