No problem with that. I have done a little digging in the code, the two methods are doing things differently (different records). If either one is set to true, it prints the gridlines. If both are false, it does not. I'm not around my excel book to check to see if either one is the prefered method (GridSet or PrintGridlines). From empiracle studies of what excel does, it only changes the printGridlines and leaves gridset alone when it comes to setting gridlines. So, if there is no complaints during the weekend, I'll follow Avik's suggestion Monday and mark the gridset as depricated in the user model (we might find a good use for the record later and there is no point in removing functional code) and remove if the the 3.0 branch.
Shawn -----Original Message----- From: Avik Sengupta [mailto:[EMAIL PROTECTED] Sent: Friday, July 25, 2003 12:24 PM To: POI Developers List Subject: Re: Method duplication My personal preference would be to deprecate it in 2.0 and remove it in 3.0 -------Original Message------- > From: Laubach Shawn Contr OC-ALC/PSB <[EMAIL PROTECTED]> > Subject: Method duplication > Sent: 25 Jul 2003 19:55:11 > > There is two sets of methods in HSSFSheet that do the same thing: > > 1. Set whether gridlines are printed: setGridsPrinted and > setPrintGridlines > 2. Check whether gridlines are printed: isGridsPrinted and > isPrintGridlines > > The amount of code is a duplicate is 6 lines (in the way that it is > indented) so it really is not much of an issue. I'm just curious if we want > to start cleaning this up at the head while it is just getting started. I'm > also curious which set of procedures is used more often. > > My preference is to get rid of the GridsPrinted methods and go with the > others (there are now methods called setDisplayGridlines, > isDisplayGridlines, and similar ones for formulas and row/column headings). > I don't care whether we depricate one for now and remove it later, or say > that it was duplicated and just remove it at the head. I'm just trying to > get a response to determine the best path. > > Shawn > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -------Original Message------- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
