Right, I was just mentioning that 20696 was probably only half the issue.
On 7/27/03 3:36 PM, "Avik Sengupta" <[EMAIL PROTECTED]> wrote:
> As far as i can see, this patch only addresses the "asking for
> "hellosheet" should also retrieve HelloSheet..." part
>
> I dunno about the write, which should deal with case preservation (tho i
> imagine it should be that way).. so
> i think this patch itself is not incompatible with "case preserving but case
> insensitive"
>
> .. but having said that, if i am missing something, i wouldnt be surprised.
>
>
>
> -------Original Message-------
>> From: Andrew C. Oliver <[EMAIL PROTECTED]>
>> Subject: Re: cvs commit:
>> jakarta-poi/src/java/org/apache/poi/hssf/model Workbook.java
>> Sent: 28 Jul 2003 00:12:29
>>
>> This is probably still wrong, we should be "case preserving but case
>> insensitive" like windows. This means that if they want to change
>> hellosheet to HelloSheet it should be possible but that asking for
>> "hellosheet" should also retrieve HelloSheet...
>>
>> -Andy
>>
>> On 7/27/03 2:52 PM, "[EMAIL PROTECTED]" wrote:
>>
>>> avik 2003/07/27 11:52:24
>>>
>>> Modified: src/java/org/apache/poi/hssf/model Workbook.java
>>> Log:
>>> MERGE from REL_2_BRANCH: Bug id 20696
>>> Workbook.getSheetIndex() needs to ignore case.
>>> Submitted by Eric Lander
>>>
>>> Revision Changes Path
>>> 1.31 +1 -1
>>> jakarta-poi/src/java/org/apache/poi/hssf/model/Workbook.java
>>>
>>> Index: Workbook.java
>>> ===================================================================
>>> RCS file:
>>> /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Workbook.java,v
>>> retrieving revision 1.30
>>> retrieving revision 1.31
>>> diff -u -r1.30 -r1.31
>>> --- Workbook.java 26 Jun 2003 13:33:47 -0000 1.30
>>> +++ Workbook.java 27 Jul 2003 18:52:24 -0000 1.31
>>> @@ -513,7 +513,7 @@
>>> for (int k = 0; k < boundsheets.size(); k++) {
>>> String sheet = getSheetName(k);
>>>
>>> - if (sheet.equals(name)) {
>>> + if (sheet.equalsIgnoreCase(name)) {
>>> retval = k;
>>> break;
>>> }
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>
>> --
>> Andrew C. Oliver
>> http://www.superlinksoftware.com/poi.jsp
>> Custom enhancements and Commercial Implementation for Jakarta POI
>>
>> http://jakarta.apache.org/poi
>> For Java and Excel, Got POI?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
> -------Original Message-------
>
>
--
Andrew C. Oliver
http://www.superlinksoftware.com/poi.jsp
Custom enhancements and Commercial Implementation for Jakarta POI
http://jakarta.apache.org/poi
For Java and Excel, Got POI?
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
