Ok here is my original patch. And yes Avik what you say about shared formulas not being stored correctly on HEAD is correct.
I have just had a look at it and it seems that I also had done some work in the ExtSST area also that fixed a bug whereby the number of buckets could not exceed 128. I am not sure if this patch made it on its own or not.
I believe that this patch was produced against the head, but I haven't tried to apply the patch yet. I suggest having a look through it to see if it looks ok before applying it. I don't really have the ability to work on it at the moment.
I have attached the patch plus the 10 new files. Just one thing that needs to be addressed is in ValueRecordsAggregate, the parsing of the shared formula records when an ARRAY follows the formula (rather than a string) needs to be completed (I never had any excel files to test against). So I guess my patch isn't 100% complete yet.
Anyhow hope that it helps.
Jason
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, 28 January 2004 12:47 PM
To: [EMAIL PROTECTED]
Subject: ValueRecords and SharedFormulas
The current(branch) method for retaining shared formulas will not work on HEAD.
Currently, we add a SharedFormulaRecord to a FormulaRecordAggregate when we see
one. However, for HEAD, no record objects other than ValueRecordAggregate are
stored, only the underlying data is stored in VRA, and Record's created on
demand. Andy, correct me if I am wrong.
So bottomline, in such a scenario, it might be easier to support SharedFormula's
by breaking them up to real formula's at read time. will increase re-written
excel size ... but ... is easiest.
If I remember right, Jason had a patch for it.. can try and add it in? Maybe if
you can mail it, we can all have a play around with it.
I am also concerned about the lack of unit tests for ValueRecordAggregate, given
the amount of work that class does in the new scheme of things, but thats a
story for another day.
Regards
-
Avik
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------------------------------------------------------
This e-mail (including attachments) is confidential information of Australian Submarine Corporation Pty Limited (ASC). It may also be legally privileged. Unauthorised use and disclosure is prohibited. ASC is not taken to have waived confidentiality or privilege if this e-mail was sent to you in error. If you have received it in error, please notify the sender promptly. While ASC takes steps to identify and eliminate viruses, it cannot confirm that this e-mail is free from them. You should scan this e-mail for viruses before it is used. The statements in this e-mail are those of the sender only, unless specifically stated to be those of ASC by someone with authority to do so.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
