DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=34828>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34828 ------- Additional Comments From [EMAIL PROTECTED] 2005-05-10 16:43 ------- **** **** **** **** **** **** **** **** **** **** **** Note: I goofed up a bit on the second **** **** version of the patch #14979 **** **** As a result, you may have to apply the **** **** patch to /src/scratchpad/src instead of **** **** the root folder **** **** **** **** **** **** **** **** **** **** **** Avik, Thanks for the encouraging response 1. Ptg and Eval: Delegating or extending? Initially I had an impl that added hooks into *Ptgs to get/store values. But with input from you and Andy I realised that integrating tightly with Ptgs would mean that the code could not go in until it was completely tested (read a long long time :) IMHO, having Evals separate from Ptg is not too bad since there are only so many *Evals and all the important Evals have been covered. Delegation has the advantage (in this case atleast) of decoupling FormulaParser from FormulaEvaluator. But I guess extending from Ptg could also work... 2. Functions in one class or one class per function? Honestly, I did not give this much thought when I designed - I just assumed one class per function was superior. Thinking about it now, it seems like multiple functions in one class is an alternative - though wrt maintainability i think it would be easier to test-develop-maintain individual classes than one big class. Some of the function implementations themselves can be quite big themselves, so one huge class would be /really/ huge. Also one function per class should make it easier to organize unit tests. Unless one class per function causes problems, I'd vote for one class per function. 3. Testing... Unit testing would be a big effort. Almost as big as writing individual functions, a distributed effort would be great! 4. My eclipse... Yeah, sorry about that. I have two different versions of eclipse, I still havent taught one of them not to do the default comments :) 5. Under contruction: The work on core eval classes is not yet "complete". I think there is need for a BlankEval class to handle empty cells - which are currently being handled as StringEval(""). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
