I started of trying to implement fix for 35288 but realised that FormulaRecord assumes and stores only double value as the result of the formula.
I checked OO documentation (pg 163 of http://sc.openoffice.org/excelfileformat.pdf) and it has description of how excel stores different value types for a formula result. So the patch attempts to do just that... ... but I assumed that for string formulas, the value is not stored since the value bytes are fixed length (8 bytes) so cannot hold a String of arbitrary length. Now, FormulaRecord can accept and serialize values for formula of types other than double, this will enable a fix for 35288 (since instead of casting to specific Record, we hace option of casting to FormulaRecord too since now it can accept different data types in the setvalue) (hope I made some sense :) ~ amol > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 09, 2005 1:39 PM > To: [email protected] > Subject: Re: DO NOT REPLY [Bug 35290] - FormulaRecord > getValue &setValue > enhancement > > > Amol, > > Can you please talk us thru this patch.. I am not clear what > it does. In > particular, I am not sure how this interacts with > StringRecord. Also does this > help with your other bug (35288) > > Thanks for the patch. > > Regards > - > Avik > > > Quoting [EMAIL PROTECTED]: > > > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� > > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT > > <http://issues.apache.org/bugzilla/show_bug.cgi?id=35290>. > > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� > > INSERTED IN THE BUG DATABASE. > > > > http://issues.apache.org/bugzilla/show_bug.cgi?id=35290 > > > > > > > > > > > > ------- Additional Comments From [EMAIL PROTECTED] > 2005-06-09 18:37 ------- > > Created an attachment (id=15355) > > --> > (http://issues.apache.org/bugzilla/attachment.cgi?id=15355&act > ion=view) > > [PATCH] Enhancements to FormulaRecord for reading > calculated value of formula > > > > Prior to this Patch, FormulaRecord ignored non numeric values > > (treated them as > > UNKNOWN). This patch modifies FormulaRecord so that it correctly > > identifies the > > type of the value and stores it. Testcases have been > included in patch. > > > > Results were verified by running BiffView (since > FormulaRecord.toString() has > > also been modified accordingly). > > > > -- > > Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > Mailing List: http://jakarta.apache.org/site/mail2.html#poi > The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
