Rainer Klute wrote:

Regarding HPSF the CVS HEAD is stable. If you need any codepages that
are unsupported yet, they can easily be added.



I had a look at the VariantSupport class, and it seems to be pretty straight-forward to add new types. If we find any that aren't there, I'll submit patches.

However...

I've just discovered that the dictionary in the custom property set isn't being read with the codepage specified for that property set.

I've tracked the issue down to the methor Property.readDictionary, which is doing the reading manually whereas Property itself uses VariantSupport.read() to perform all the decoding.

I'm doing some twiddling, doing a VariantSupport.codepageToEncoding call to determine how to create the string, but I'm not sure it will work because I don't fully understand what the length means in this case. If the code page is 65001 (UTF-8), is the length the length in bytes or the length in characters? If it's the length in bytes, this becomes easy, and it seems to work for the test file we have. If it's the length in characters, it might take longer to get right.

I'll submit a patch in a few minutes if I can clean up my codesufficiently, but it won't be a clean patch so you'll probably have to rearrange it a little. :-/

Daniel

--
Daniel Noll

NUIX Pty Ltd
Level 8, 143 York Street, Sydney 2000
Phone: (02) 9283 9010
Fax:   (02) 9283 9020

This message is intended only for the named recipient. If you are not
the intended recipient you are notified that disclosing, copying,
distributing or taking any action in reliance on the contents of this
message or attachment is strictly prohibited.


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta Poi Project: http://jakarta.apache.org/poi/



Reply via email to