-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johan Euphrosine wrote: > Hi, > > When testing jpoker tourney reconnection, I came across the > following server bug: http://pastebin.com/f66c242a6 > > Later on irc://#pokersource Loic advised the following: > > (05:12:15 PM) dachary: if self.serial2client.has_key(serial) and > self.serial2client[serial].user.isLogged(): (05:12:25 PM) dachary: > this is a fix for the following bug (05:12:31 PM) dachary: 1) a > user joins a table (05:12:35 PM) dachary: 2) the hand starts > (05:12:38 PM) dachary: 3) the user logs out (05:12:52 PM) dachary: > 4) another player joins the table (05:14:40 PM) dachary: 5) > getPlayerInfo is called on pokeravatar for the player that has been > logged out because the hand is not over and returns an error > (05:15:11 PM) dachary: The fix instructs the getPlayerInfo at the > table level to query the database for user information when the > player is not logged in instead of relying on obsolete in core > information > > I believe the attached patch reproduce and correct the issue, while > following Loic's guidelines. I've applied the patch. A mockup in the test-pokertable.py.in was missing the user class and the tests failed. I've fixed it and commited the change.
Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkiSrNsACgkQ8dLMyEl6F23BgACfdB+SldvxCIWsmvdtBiq5fiTp hTIAoIzgpybDv8JhsSoi/i2ePs/1r1Sc =inkh -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[EMAIL PROTECTED] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
