-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> > I'll investigate this now. You can find me on #pokersource if you > are willing to talk more. pokerengineconfig.py which holds most of the code dealing with libxml2 already had provisions to call the libxml2 deallocation functions explicitly because they are not called automatically (which is a bug demonstrated by your patch). The Config.load function failed to call the deallocation function and libxml2 was leaking. As it turns out, this load function is called every time an avatar creates a new game and is therefore the primary source of the recent leaks. I've fixed the problem with the patch below: http://svn.gna.org/viewcvs/pokersource/trunk/poker-engine/pokerengine/pokerengineconfig.py?rev=5321&view=diff&r1=5321&r2=5320&p1=trunk/poker-engine/pokerengine/pokerengineconfig.py&p2=/trunk/poker-engine/pokerengine/pokerengineconfig.py In order to help prevent similar problems in the future (and guard us against accidental removal of a call to a deallocation function), I've also adapted the tests you wrote to detect leaks. http://svn.gna.org/viewcvs/pokersource/trunk/poker-engine/tests/libxml2leak.py.in?rev=5321&view=markup They are now part of the "make check" test suite and I've tried to make them fast and accurate, which is a little tricky. I did not bother to make them run on non GNU/Linux operating systems. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAklTk+wACgkQ8dLMyEl6F20cdgCfQaghjyIGc0tT7IaJVJ/mIB++ sVQAnR1WKL9DxWiL7khE0HWxMRwD2doG =zugC -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[email protected] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
