Packaging the new version of poker-eval, Fedora's lint checker for packages has indicated that it does not like the fact that a library is using the exit system call. Here is the rationale:
"This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation." I have created a patch[1] to appease the lint checker. I removed the printf in combinations.c because the single calling function will fprintf(stderr,...) on a return value of NULL. Also, the change in enumerate.h should probably output to stderr, but I did not include that with the patch. Please apply if there are no problems. Thanks, -Chris [1] http://xulchris.fedorapeople.org/poker-eval-135.0-exit.patch _______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
