Loic Dachary wrote:
> Note that there are two ways the poker bot code will evolve in the near
> future. First, the tomfmason patch that has been sitting for a very long
> time in a branch can be injected (it has better coverage, I
> think). Second, by the end of August Guy said he would publish a Free
> Software bot he has been working on this year, including an adapter for
> the pokersource protocol. When and if this happens we could obsolete the
> current bot or turn it into a test only bot (which is the reason why it
> was written in the first place).
Ok, all very good arguments for not writing any tests for the existing bot
code. So I will not.
> > ../pokernetwork/countfilter 16 0 0% 21-41
> Yes : however I think it already is covered and the reason why it does
> not show is because of a flaw in the coverage code.
Actually, this is not the case here. It was merely that
test-countfilter.py wasn't in Makefile.am. I fixed that:
http://svn.gna.org/viewcvs/pokersource?rev=5998&view=rev
However, the problem you mention *is* the problem with this one:
> > ../pokernetwork/nullfilter 2 0 0% 23-24
I even wrote a simple test file covering directly with a unit test:
http://svn.gna.org/viewcvs/pokersource?rev=6002&view=rev
and the coverage report still fails! I have filed a bug about this:
https://gna.org/bugs/?13864
As I say in that bug ticket, I am not sure what we can do about this,
because we have to upgrade to coverage.py 3.0, which appears not to be
packaged for *anything* yet -- I've filed a few distribution bugs. It
would be great if we can switch to coverage.py 3.0, because it's much
faster. I put numbers in the bug ticket.
> > ../pokernetwork/pokerlock 103 102 99% 147
I will take a look at this one again, but I think I need some help. I
wrote a test that covers it and it "locks" up intermittently. :) I could
use some help on this if an expert in threading.Thread can help me. :)
> [OLDpokerclientpackets] is worth covering and should be easy too.
This is done (although not merged to trunk yet):
http://svn.gna.org/viewcvs/pokersource?rev=6003&view=rev
> > ../pokernetwork/proxyfilter 79 77 97% 37,
> > 110
This is done (although not merged to trunk yet):
http://svn.gna.org/viewcvs/pokersource?rev=6004&view=rev
http://svn.gna.org/viewcvs/pokersource?rev=6005&view=rev
-- bkuhn
_______________________________________________
Pokersource-users mailing list
[email protected]
https://mail.gna.org/listinfo/pokersource-users
