-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bradley M. Kuhn wrote: > Loic wrote on Tuesday the 8th: > >> I very much doubt there will be any benefit in making an actual >> bot run in the tests. The connection pattern is specific but the >> rest of the bot actions is not. > > After I sent my previous message, I took a look at what I'd been > working on before with fresh eyes. This solution *does* work, and > given that I'd already put effort into it before sending my last > message, it was actually easier to use this setup of > deferred's/reactor.callLater()'s you see in nBotsAndOneLivePlayer() > in the attached patch. > > I am therefore planning to merge this bug-tests branch at r6232 > into trunk, the changset for which is shown in the attached patch. > I plan to use this commit message: > > Test to exhibit bug#14139. > > This new test in test-bug-14139.py.in exhibits bug#14139 by adding > bots and user and showing that a hand does not start. If the bug > is closed, this test should pass as written. > > Note that some changes were needed in test-pokeravatar.py.in in > some of the helper functions. This doesn't impact the functioning > of those test. Much of the changes move some methods to base > classes; the rest make minor changes to helper functions to handle > the existence of the bots at the tables and slightly different uses > of the helper functions. > > Finally, a few files that should have been in .gitignore are added. > This will be meaningless currently to anyone but those using > git-svn. I'm glad you made it work. You have my vote to apply the patch.
Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkqu138ACgkQ8dLMyEl6F21/LgCfe2RZODFT9dXCCFIwNX9kaq5H PaYAn0wgM0mnsCYjrLKQUdmxEdlASeZe =R6oM -----END PGP SIGNATURE-----
<<attachment: loic.vcf>>
_______________________________________________ Pokersource-users mailing list Pokersource-users@gna.org https://mail.gna.org/listinfo/pokersource-users
