On Fri, 2010-01-01 at 14:00 +0100, Johan Euphrosine wrote: > > I also worked on implemeting: > http://drupal-dev.pokersource.info/trac/ticket/6 > "poker: small profile" > > You can run tests from here: > http://drupal-kez.pokersource.info/planc/test-poker.html > > And try it there by hovering the player avatar: > http://drupal-kez.pokersource.info/planc/skin/table.html#jpoker_05_1_selfPlayerInGame_autoActionCheck > > Remaining issues are: > * fetch town/country from drupal through > opensocial/ShindigIntegrator when player_arrive, and assign > them > in the player object
Today, I fixed remaining issues regarding "poker: small profile" implementation: As described in the following ticket: http://drupal-dev.pokersource.info/trac/ticket/6 I added and tested support for opensocial Address Field in shindig_integrator, and submitted it upstream: http://drupal.org/node/673756 I've also updated and implemented new tests: "getPerson opensocial API test": http://drupal-kez.pokersource.info/drupal6/sites/all/modules/shindig_integrator/shindig/php/gadgets/ifr?bpc=1&nocache=1&url=http://drupal-kez.pokersource.info/planc/person-opensocial.xml "poker small profiles tests": http://drupal-kez.pokersource.info/planc/test-poker.html?poker%20module%3A%20seat_hover%20display%2Fhide%20small%20profile "opensocial integration tests": http://drupal-kez.pokersource.info/drupal6/sites/all/modules/shindig_integrator/shindig/php/gadgets/ifr?bpc=1&nocache=1&url=http://drupal-kez.pokersource.info/planc/test-jpoker-opensocial.xml "skin tests": http://drupal-kez.pokersource.info/planc/skin/table.html Please note that I added tests for the following callbacks in test-poker.opensocial.js: $.jpoker.plugins.table.callback.display_done $.jpoker.plugins.player.callback.display_done These tests override JsonRpcContainer.prototype.requestData in order to mockup opensocial request for Gender and Addresses. While manually testing on http://drupal-kez.pokersource.info/drupal6/ I found a remaining issue: "No default image in small profile if avatar has not been set" Which may be fixed by adding a background-image throught CSS on poker_avatar div (img parent). We also discussed implementation of gift animation in jpoker: http://drupal-dev.pokersource.info/trac/ticket/9 We checked that drupal os_poker module notify a user who have been given a gift throught jQuery event system. mongolito404 suggested that jpoker opensocial gadget could bind a fonction in the parent jQuery instance using window.top as described in: http://drupal-dev.pokersource.info/trac/ticket/9#comment:1 And I asked the following question: http://drupal-dev.pokersource.info/trac/ticket/9#comment:2 "I believe only the user who is given the gift is notified throught the os_poker message API. Does this mean that the gift animation should only be displayed in this user browser ? " -- Johan Euphrosine <pro...@aminche.com>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Pokersource-users mailing list Pokersource-users@gna.org https://mail.gna.org/listinfo/pokersource-users
