Nigel Kukard wrote:

>> So, I've spent some time on debugging and I think I found the bug. Maybe
>> your patch addresses the same issue (the response from the quota module
>> is not cleared when the quota is not reached), but unfortunately it did
>> not work. The attached diff solved my problem -- if verdict is not set,
>> I explicitly set the (in my opinion) correct protocol_response.
> 
> This would unfortunately nuke any response another module has set.

Of course. But the decision of the quota module only comes to effect
when the previous modules gave no decision - in all cases except
PROT_PASS processing consecutive modules is skipped (protocol response
returns CBP_STOP). So maybe there should be some prioritization of modules?


> What I did fix is adding DEFER to the Quotas module, but seeing as this
> wasn't in there before, I cannot imaging how it was working.


Well, without the if-block handling the 'defer' case the final else
block comes to effect, responding with an error. I've tried this as well.

>                 $server->log(LOG_ERR,"[QUOTAS] Unknown Verdict specification 
> in access control '$verdict'");
>                 return $server->protocol_response(PROTO_DATA_ERROR);



> Try remove the text in your data field in your quota definition, v2
> should set this to a more terse reason which may lead to the part of
> code its coming from.
> 
>> Maybe you find a better solution for this issue...
> 
> Attached the addition of DEFER.
> 
> Failing it still doesn't work, paste your current DB entries and a full
> log of the above with all debugging options, I'll take a look and see if
> I can't see anything.

Sorry, all mails are already sent so I can not do further
tests/debugging. Maybe the next time when I have to send a newsletter I
can provide you more information.

thanks,
quam
-- 
Markus Quaritsch
E: [EMAIL PROTECTED]
W: www.qwws.net
P: +43 650 7997638

Attachment: signature.asc
Description: OpenPGP digital signature

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
policyd-users mailing list
policyd-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/policyd-users

Reply via email to