> rc = writeHeaders(entry->fd, &entry->body_offset, object, NULL, 0);
> if(rc == -2) {
> rc = rewriteEntry(object);
> if(rc < 0) return 0;
> return 1;
> }
> As far as I can see, the writeHeaders() would not return a -2, it can only
> return -1 or something positive. Can someone explain what error the code is
> trying to catch.
It's a bug that was introduced when I added support for headers beyond 4 kB.
If you check a 0.9.* version of Polipo, you'll see the correct code.
It was supposed to deal with the case when we overflow the body_offset
of the entry, and need to choose a larger one. It's a rather rare
case, and the failure will only cause us to loose the on-disk entry,
which will be refetched from the origin server, which is why nobody
complained.
I'll fix it this week-end. Thanks for the report.
Juliusz
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
