I don't usually post, but I thought I'd share a suggestion for the code:
+ va_copy(args_copy, args);
rc = vsnprintf(syslogBuf + syslogBufLength,
syslogBufSize - syslogBufLength,
- f, args);
+ f, args_copy);
+ va_end(args);
--You probably want va_end(args_copy) here, since that's the va_list
that you just used. Please correct me if I'm wrong.
Thanks,
Greg
2009/4/27 Juliusz Chroboczek <[email protected]>:
> Nix, could you please review this patch?
>
> http://mid.gmane.org/[email protected]
>
> (I still wish I hadn't agreed to merge the syslog code -- we keep hitting
> bugs in it, and since I don't use syslog, I don't test it myself.)
>
> Juliusz
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensign option that enables unlimited
> royalty-free distribution of the report engine for externally facing
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Polipo-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/polipo-users
>
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
