Many thanks for your advises, I've learn a lot. > > Please do not dispatch on #ifdef WIN32, as this will break compilation > under Cygwin. >
I've test it under Cygwin ,it works fine. There is not macro WIN32 under
Cygwin.could you give me more detail's?
>
> >>Please do not use CC++-style comments, they break compilation under SYSV.
>
i have changed in the new patch.
>
> Please do not change the behaviour of Polipo -- if you want to make an
> incompatible change, please make it into a separate patch and discuss it
> on this list. There are good reasons why Polipo doesn't allow relative
> paths in the web server's root directory, and why it doesn't silently
> create the directory when it doesn't exist -- doing otherwise raises
> some significant security issues.
>
I've changed in the new patch. thanks,i will remember it.
>
> Please do not include unrelated changes in your portability patch, send
> a separate patch instead -- I've noticed the change to the ETag parser,
> and the typo fix in object.c which don't belong in this patch, since
> they are not specific to Windows.
>
I've accepted in the new patch.
>
> The change to mktime_gmt is wrong -- an empty TZ variable is different
> from no TZ variable at all.
>
yes,but an empty TZ variable will cause crash under VC2008/2010 when using
sprintf_a. so i rewrite a new one for VC:
time_t
mktime_gmt(struct tm *tm)
{
time_t t;
static int bias = -1;
if(bias == -1)
{
time_t curr = time(NULL);
struct tm * p = gmtime(&curr);
time_t gmtcurr = mktime(p);
bias = curr-gmtcurr ;
}
t = mktime(tm)+bias;
/ * printf("mktime_gmt2: %d\n", t ); */
return t;
}
>
> Please remove the stdint.h emulation file. Instead, you should just
> typedef my_uint32_t in md5import.c.
>
I've changed in the new patch.
>
> Please do not unconditionally remove the compatibility macro for va_copy.
>
> What's Iphlpapi.lib? Will it break compilation under mingw?
>
I've remove dependency on Iphlpapi.lib.it will not break compilation under
mingw+win32api.
i add the new port patch as an attach file.now it can be compiled under
Mingw+MSYS/VC2008/VC2010/Cygwin, all work fine .
vcpolipo.patch
Description: Binary data
------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________ Polipo-users mailing list Polipo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/polipo-users
