> What do you think ?

That it's a good idea, but needs some more work.

First, I think you're not resetting nameserverAddress correctly.

Second, there's no need for a lock -- Polipo is event-driven, not
threaded code.  The race condition is elsewhere -- if a reply arrives
between resetDns and establishDnsSocket, you'll lose a reply.  I suggest
calling establishDnsSocket from within resetDns.

Third, please use four spaces for indentation, and avoid C99 comments (//).

(You'll want to ``git rebase -i'' and ``git push --force'' in order to
provide me with a clean patch history after you make your changes.)

-- Juliusz

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Polipo-users mailing list
Polipo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/polipo-users

Reply via email to