"Will Manley" <william.man...@youview.com> wrote: > > Fabian Keil <freebsd-lis...@fabiankeil.de> wrote: > > > > "Will Manley" <william.man...@youview.com> wrote: > > > > > I've pushed up a few patches to github which myself and my colleagues at > > > YouView have been working on. I would appreciate a review if possible. > > > > > > In summary: > > > * automated-testing introduces systemd socket activation support and a > > > simple automated test framework. > > > * rfc5861-control-value-parsing makes polipo recognise > > > "stale-while-revalidate" and "stale-if-error" cache-control-flags > > > * fix-flags cleans up the naming of the OBJECT_TYPE, OBJECT_FLAG and > > > CACHE_CONTROL_FLAG values and fixes a typo in httpTweakCachability > > > > > > I've only tested these changes on Linux (Fedora 15) as I have no other > > > development environments available. > > > > > > You may find that the automated tests fail. In two of the cases where > > > I believe that polipo should be caching the requests it doesn't, unless > > > you kill polipo and re-start it, in which case it will happily serve > > > from disk cache. I wonder if this is related to 148f04ff "Tweak > > > cachability when reading from the disk cache." which I came across while > > > making the fix-flags changes. > > > > Could you please provide an URL for the repository that contains > > the patches, or post them directly if they aren't too large? > > > > I'd like to look at the "simple automated test framework" and > > could at least compile-test the patches on FreeBSD 10.0-CURRENT. > > Ah, how silly of me. The branches can be found at > https://github.com/wmanley/polipo/branches > > To pull them try: > git pull git://github.com/wmanley/polipo.git automated-testing
I had a look at that, but it seems fairly GNU/Linux-specific to me. It introduces dependencies on at least GNU make, bash, Linux's version of sendfile() and systemd. I suspect the systemd dependency will be a show stopper for quite a few users. Given that you are already using curl, I wonder if you considered leveraging curl's test framework instead of starting from scratch? It already contains quite a few HTTP tests and a lot of them can be used as-is to test the behaviour of a proxy, too. Currently (or at least a few month ago when I checked) there's no easy way to toggle between those that are relevant for a proxy and those that aren't, but I expect that patches to fix this would be either accepted upstream or would be easy to maintain separately. The tests currently obviously don't cover what your tests do, but could probably be extended with less effort than it would take to get the automated-testing branch working on the other platforms supported by polipo. > git pull git://github.com/wmanley/polipo.git > rfc5861-control-value-parsing I don't see the point of storing the parsed values when they could simply be ignored, but of course it doesn't really hurt either. > git pull git://github.com/wmanley/polipo.git fix-flags The clean-ups look good to me. The typo fix does, too, but I can't comment on its consequences. Fabian
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________ Polipo-users mailing list Polipo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/polipo-users
