On 08/22/2016 02:17 AM, Kalev Lember wrote:
On 08/18/2016 05:38 PM, Jeremy Linton wrote:
On 08/17/2016 03:57 PM, Colin Walters wrote:
It might be worth looking at kalev's work to see what differs.
Are the patches visible anywhere? I don't see them in those threads.
They are in https://github.com/kalev/polkit , but rather unfinished. I
think it built, but I can't recall how much (if any) runtime testing
they've gotten.
They look pretty similar, although I've got a few extra things I needed
to solve a few problems. For example the strange C++ link mode force
options, which seem to be required for automake on fedora (probably
others) without which, the resulting binaries are missing the C++
support libraries.
The one thing that is interesting is that I see you converted
JS_NewCompartmentAndGlobalObject to JS_NewGlobalObject, and passed it
the compartment options to set JSVERSION_LATEST, but never construct a
compartment. IIRC, explicit compartment construction is required to get
any of the function/variable assignments to work (and pass the unit
tests). I'm guessing that is where you stopped?
I'm actually working on something else at the moment, but I will get
back to this shortly (hopefully later this week) and re-post, minus the
#ifdef which is a pretty straightforward tweak.
_______________________________________________
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel
