Hey Rob, On Mon, Jun 30, 2014 at 10:09 PM, Rob Dodson <[email protected]> wrote: >> * How to use stylesheets inside the component: >> https://github.com/prtksxna/leafleft-map-component/issues/2 > Left a comment.
Thank you! I have fixed this > Btw, this line caught my attention > https://github.com/prtksxna/leafleft-map-component/blob/master/leaflet-map-component.html#L10 > You're hard coding a path to `bower_components` but you don't have a > guarantee that the user will have a `bower_components` dir. Using a > `.bowerrc` file, the user may have renamed their `bower_components` dir (we > often rename ours to just "components"). Depending on how leaflet works, you > may need to take their stylesheet, modify it so it's Shadow DOM friendly, > and load your own version into your elements. I had documented this concern in the first issue - http://git.io/K_klXg - and have fixed it now. >> * Should the the Leaflet library be loaded inside the main HTML or in >> the component: https://github.com/prtksxna/leafleft-map-component/issues/3 > Left a comment Fixed. >> * How can I make a change to a property without triggering >> propertyChanged: >> https://github.com/prtksxna/leafleft-map-component/issues/6 > Hm good question. Maybe you could name your zoom property something > different, like initialZoom, so it isn't called? I get really confused with difference between a property and an attribute. I don't want to call it something else as I am reflecting it on the DOM. So if you zoom the map by double clicking on it then the attribute changes too. Is there some documentation that I should refer to to understand this better? >> * How are dependent components within a single repository suppose to >> document their dependencies: >> https://github.com/prtksxna/leafleft-map-component/issues/7 > Left a comment Fixed. >> * Where can I find documentation on the `select` attribute of the >> <content> tag: https://github.com/prtksxna/leafleft-map-component/issues/8 > The select attribute just uses CSS selector syntax. This section of the spec > seems to explain everything that's allowed: > http://w3c.github.io/webcomponents/spec/shadow/#h3_satisfying-matching-criteria > Types (input, div, p), ID's, classes, attributes, and :not() I have added this to the comment and linked to the mailing list. >> * For certain elements I wasn't able to register onMutation correctly: >> https://github.com/prtksxna/leafleft-map-component/issues/9 > What's not working for you? Changing the innerHTML of the `leaflet-marker` element whether through the inspector or through JavaScript does not call the `contentChanged` - http://git.io/2Bruog - function and thus doesn't update the popup. >> I would be grateful if someone could answer these questions. Do you >> think its worth it to package it and put it on bower and web component >> registries? > sure! Done! I put it up on Bower and a few other places :) >> Should I add the rest of the Leaflet features and add >> elements for <leaflet-polygon>, <leaflet-path> etc? > sure! Hmm. I am unsure of how I want to expose the interface for these. These elements will be slightly more complicated. Maybe I should discuss that on the leaflet mailing list. > Take a look at the seed-element. It has some sample tests. The seed-element and the article related to it were very helpful. I haven't added tests yet but was able to add documentation and deploy to gh-pages using that documentation —prtksxna Follow Polymer on Google+: plus.google.com/107187849809354688692 --- You received this message because you are subscribed to the Google Groups "Polymer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/polymer-dev/CAMi5MH4tR-X-k2PeGVXzoi-b7EJSTcohJYCvH%2BN-rxNJ7YOwKg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
