FYI, we've updated a script <https://code.google.com/p/chromium/issues/detail?id=458315> in the Chromium tree so we can handle mixed line endings in Polymer elements now (by stripping away the CRs when updating elements). But I'd still encourage consistency!
On Fri, Feb 13, 2015 at 10:46 AM, Daniel Freedman <[email protected]> wrote: > Yeah all for that. The only task would be to go through all the components > and fix them up. > > On Thu, Feb 12, 2015 at 8:37 PM, Rob Dodson <[email protected]> wrote: > >> gotta get on that .editorconfig train! http://editorconfig.org/ >> >> On Thu, Feb 12, 2015 at 2:37 PM, 'Michael Giuffrida' via Polymer < >> [email protected]> wrote: >> >>> Rietveld and/or the CQ cannot apply changes when the unified diff >>> contains CRs. See discussion on chromium-dev: >>> >>> https://groups.google.com/a/chromium.org/d/msg/chromium-dev/u5KeH1lqDmY/ZzZTKdGa7IoJ >>> >>> We'll be adding a script to the tree to remove those line endings after >>> "bower install". >>> >>> On Thu, Feb 12, 2015 at 2:07 PM, Daniel Freedman <[email protected]> >>> wrote: >>> >>>> None of our tools ever cared about line endings. What breaks about >>>> mixed line endings breaks the Chromium tree? Anything beyond some linter >>>> step? >>>> >>>> On Thu, Feb 12, 2015 at 2:02 PM, Elliott Sprehn <[email protected]> >>>> wrote: >>>> >>>>> I blame Scott and his windows habit. :P >>>>> >>>>> On Thu, Feb 12, 2015 at 2:00 PM, 'Michael Giuffrida' via Polymer < >>>>> [email protected]> wrote: >>>>> >>>>>> Several Polymer files on GitHub (and when installed through bower) >>>>>> mix CRLF with LF, and it's making the Chromium tree sad. >>>>>> >>>>>> Example: >>>>>> https://github.com/Polymer/paper-checkbox/blob/master/paper-checkbox.css >>>>>> >>>>>> Polymer devs, why? <https://i.imgflip.com/hkdgs.jpg> >>>>>> >>>>>> Michael >>>>>> >>>>>> Follow Polymer on Google+: plus.google.com/107187849809354688692 >>>>>> --- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Polymer" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/polymer-dev/CACi5S_1RrSQEKzxGWhQPUzfqBSSFS6-SPkqjWDG9me9%2B05GhwA%40mail.gmail.com >>>>>> <https://groups.google.com/d/msgid/polymer-dev/CACi5S_1RrSQEKzxGWhQPUzfqBSSFS6-SPkqjWDG9me9%2B05GhwA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> >>>>> Follow Polymer on Google+: plus.google.com/107187849809354688692 >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Polymer" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/polymer-dev/CAPJYB1ieg5zD6f9_1Y%2BOW6gu%2B0xGJ6sMTi4B4Z0zHX48d8tzVw%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/polymer-dev/CAPJYB1ieg5zD6f9_1Y%2BOW6gu%2B0xGJ6sMTi4B4Z0zHX48d8tzVw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>> Follow Polymer on Google+: plus.google.com/107187849809354688692 >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Polymer" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/polymer-dev/CACi5S_0QC7qSaawkgUWmRyn5kYeh8TA5dwEQCh%3DDwxBuy3xpSA%40mail.gmail.com >>> <https://groups.google.com/d/msgid/polymer-dev/CACi5S_0QC7qSaawkgUWmRyn5kYeh8TA5dwEQCh%3DDwxBuy3xpSA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> > Follow Polymer on Google+: plus.google.com/107187849809354688692 --- You received this message because you are subscribed to the Google Groups "Polymer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/polymer-dev/CACi5S_2Pe56iFU2mpL7u-6szXrrQob2W7rD4dB%2B3qkHHp4inrQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
