Hello Aaron,here comes the second batch of patches, This time it is patches to the
Xpw library.It consists mostly of corrections to the type definitions of functions - nothing very serious. But now the build process only has 3 warnings
left.
______________________________________________ c_core.c: In function ‘_pop_set_async_check’:c_core.c:1074:41: warning: ‘return’ with no value, in function returning non-void
1074 | if (!FD_ISSET(fd, &async_fds[set])) return;
| ^~~~~~
c_core.c:1066:6: note: declared here
1066 | bool _pop_set_async_check(on, fd, set)
| ^~~~~~~~~~~~~~~~~~~~
Text.c: In function ‘WriteAtCursor’:
Text.c:2380:9: warning: ‘return’ with no value, in function
returning non-void
2380 | return;
| ^~~~~~
Text.c:2365:21: note: declared here
2365 | static XpwMethodRet WriteAtCursor(w, string, len)
| ^~~~~~~~~~~~~
Text.c: In function ‘XpwSetSelection’:
Text.c:2861:38: warning: ‘return’ with no value, in function
returning non-void
2861 | if (context->widget != NULL) return; /* already
own the selection */
| ^~~~~~
Text.c:2828:14: note: declared here
2828 | XpwMethodRet XpwSetSelection(w, location, string,
nbytes, lose_p, client)
| ^~~~~~~~~~~~~~~
______________________________________________________
The one in c_core.c is the already mentioned one in my previous
mail and
there are now still two in Text.c in the Xpw library.In all three cases it is a function that is defined to return a value, but doesn't under certain circumstances. This does indeed look very suspicious to me and I think it would be worth to have a closer look at
it by somebody more knowledgeable than me. Anyway here are the patches:
poplog-Xpw-patches.tgz
Description: Xpw patches
Andreas -- ceterum censeo redmondinem esse delendam
