On Wednesday 04 October 2006 04:17, Pino Toscano wrote: > I've written a patch for supporting sounds and page actions, and an > addition patch for the Qt4 backend to support these new features. I only had a quick look at the code - nothing too objectionable :-) * I would like to see a unit test (and whatever test files are necessary) that verifies all of the functionality. * There are a couple of new files that don't have appropriate (GPL) licensing. Please fix. * A couple of non-ascii characters in the API documentation (for the SoundEncoding enum), and one API documentation entry that could be clearer (for channels() - did you want something like: "The number of sound channels to use to play the data"? * You appear to be documenting SoundData, not SoundObject. Also, it would be nice to provide an overview of how sound works in this API. As a minimum, please provide a reference to the relevant section in the PDF spec.
Brad
pgpsyNKRgGPfE.pgp
Description: PGP signature
_______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
