On Sunday 13 April 2008 09:32:20 am Albert Astals Cid wrote: > Hi, poppler is not prepared at all for 16 bits per component images, > everywhere it assumes a component of the color fits into a Guchar (8 bits). > > You can see the consequences with the pdf present at > http://bugs.kde.org/show_bug.cgi?id=158165 > > I have attached a 5 line patch that "fools" poppler and makes it use the > high 8 bits and discard the other 8. > > This makes it "work" but it's obviously a workaround and not the real > solution and i have only this pdf using 16 bits per component and it's > really a "test document" not a real one. > > So i'm hesitating if incorporating the patch (with comments explaining the > workaround) or not doing it. As long as the comments explain it (e.g. a pointer to the bug, and a little explanation of the workaround), I'd suggest applying it.
It isn't very intrusive, and shouldn't affect much else. You can revisit it / revert it if the next example has a lot of problems. Brad _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
