Hi, I reviewed, polished and pushed your patch, thanks! There were few quirks, but mostly small things (like indentation).
> So far the thumbnail images seem to be 24-bit RGB; I don't know if > that's always going to be true. For now I left this assumption; but it should be checked which format is actually returned by Page::loadThumb(), and in case fill the QImage by adapting the input data. > I tested it by modifying the demo program to have a thumbnails dock > window, using the usual QTableView, which isn't so great because > QIcons in a QTableView are a rather tiny size by default, but at least > you can see that the thumbnails got generated correctly. I will try > to use a QGraphicsView in my own program for that. I changed that by making use of QListWidget for it, should looks better now. Most probably can be improved, but at least as first approach works ;) Keep up the good work! -- Pino Toscano
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
