Excerpts from [email protected]'s message of jue mar 31 14:19:24 +0200 2011: > Hi, > > now patch 1 contains the memleak fix.
pushed to both master and poppler-0.16 branches. Thanks! > and patch2 is the updated patch > addressing review comments. Great, I still have a couple of comments about the patch, but Pino had an idea to add a new class to handle additional actions in a more generic way. Pino? > > Greets > > José > > From 967cb1ef4acba2b517eb97cace9fab770388bb58 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jos=C3=A9=20Aliste?= <[email protected]> > Date: Tue, 29 Mar 2011 04:27:15 -0400 > Subject: [PATCH 2/2] Parse additionActions dictionary for Widget annots. > --- > poppler/Annot.cc | 71 ++++++++++++++++++++++++++++++++++++++++++++++------- > poppler/Annot.h | 29 +++++++++++++++++---- > 2 files changed, 84 insertions(+), 16 deletions(-) > diff --git a/poppler/Annot.cc b/poppler/Annot.cc > index 7d1136c..dbf1778 100644 > --- a/poppler/Annot.cc > +++ b/poppler/Annot.cc > @@ -1350,6 +1350,45 @@ void Annot::draw(Gfx *gfx, GBool printing) { > obj.free(); > } > +// Parse Actions in AdditionalActionss dictionary that are common to Screen > and Widget annots > +void Annot::parseAdditionalActionss (LinkAction **additionActions, Object > *addActionDict, GooString *baseURI) Actionss? > if (action) > delete action; > - > - if (additionActions) > - delete additionActions; > - > + > + for (int i = 0; i < EventsNumber; i++) > + delete additionActions[i]; > + Wrong indentation here. > if (parent) > delete parent; > } > @@ -2758,10 +2797,19 @@ void AnnotWidget::initialize(XRef *xrefA, Catalog > *catalog, Dict *dict) { > } > obj1.free(); Thanks! -- Carlos Garcia Campos PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
signature.asc
Description: PGP signature
_______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
