El Dissabte, 3 de novembre de 2012, a les 11:38:48, Adam Reichold va escriure: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hello Fabio, > > I applied and tested your patches from yesterday and they do solve the > problem for me. Thanks!
pushed! Albert > > Regards, Adam. > > On 17.10.2012 20:45, Fabio D'Urso wrote: > > On Wednesday, October 17, 2012 08:51:37 AM Adam Reichold wrote: > >> Just noticed something odd: When I save a modified copy of a PDF > >> file with a custom text entered into a combo box form field and > >> reload it, the new file still shows the custom text but > >> FormWidgetChoice::getEditChoice returns a null string... > >> > >> Could this be a problem with the parsing in FormFieldChoice? > > > > Seems like it's not been implemented. > > > > In FormFieldChoice::FormFieldChoice (poppler/Form.cc), editedChoice > > is initially assigned NULL and never changed. I think it should be > > given the value in /V if /V is a string and doesn't match any of > > the predefined choices. Note that the piece of code that parses /V > > is one of the things that I'm working on (thread: "Patches for form > > choice fields"). > > > > By the way, I noticed that FormFieldChoice::setEditChoice > > internally calls unselectAll to deselect predefined options. Maybe > > select/selectAll/etc.. should similarly set editedChoice to NULL? > > > > Fabio > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.19 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ > > iQEcBAEBAgAGBQJQlPQ4AAoJEPSSjE3STU34GiEH/3RfG6TqAMdpqU99xI7m6Xls > NT8Mb/r4t/WFrTe4dqdHT4zLt6yeccx9FbGI4m0WRiRx8jr1r1b3MFQ+v/s4/7hX > 2SH47dKvcue07aEtLBCoY+ly2M5tpMTRvroaeqKPanng5MLFMCDBO3Mk7uMm7YIS > AWVTFPMGecV+zKetj/Mk3c1TWIzw5pCn7LcqBUKag7lm3RL/XQUAG10s9imRzprf > rh7PnqF5VXhSZVGJtqbPzROcPeZSYZxW91FLp16jkr5s+Orm1TC1uk6gRC/WfX6O > 4ZptNLxkKB+vEiBRinX7GPW0Rrz3zG5OE5m3ol4iKifeQakjfK21YOzzb0tN8yw= > =s6Uh > -----END PGP SIGNATURE----- > _______________________________________________ > poppler mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/poppler _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
